Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Conversation

killerpanda101
Copy link
Contributor

@killerpanda101 killerpanda101 commented Oct 23, 2020

Description

Michelin resturent data scraper

Fixes #114

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

@tusharnankani
Copy link
Member

Please follow the Code of Conduct.
Which issue is this PR referred to? Please link your PR to the respective issue, or create one here.

@killerpanda101
Copy link
Contributor Author

sorry should have mentioned it
Michelin star restaurants scraper #114
The issue was closed by the GitHub bot, let me know if you want me to create a new one.

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 24, 2020

@killerpanda101 add a few more comments and refer to existing scripts to check the proper requirements file format.

Enclose the main function call under -- if __name__ == "__main__":

Add a screenshot of the script in action, like how to execute it from the cli and what kinda output it gives, stuff like that.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@killerpanda101 add a few more comments and refer to existing scripts to check the proper requirements file format.
Enclose the main function call under -- if name == "main":
Add a screenshot of the script in action, like how to execute it from the cli and what kinda output it gives, stuff like that.

Hope you are working on this^

Also, please comment on your code for better understanding and remove unnecessary empty lines. Also, please add a bit more description of your script in the README.

@AdityaJ7
Copy link
Member

@allcontributors please add @killerpanda101 for code

@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @killerpanda101! 🎉

@AdityaJ7 AdityaJ7 removed the request for review from chavarera October 27, 2020 04:06
@mergify mergify bot merged commit f989864 into Python-World:master Oct 27, 2020
@github-actions
Copy link

Python World does not accept pull requests on this repository anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2022
@mergify mergify bot added the nice-job label Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Michelin star restaurants scraper
3 participants