Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Json2yaml #66

Merged
merged 8 commits into from
Oct 2, 2020
Merged

Json2yaml #66

merged 8 commits into from
Oct 2, 2020

Conversation

mendoza
Copy link

@mendoza mendoza commented Oct 1, 2020

Description

It converts a json file to a yaml file

Fixes #17

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Readme errors.
And, comment your code for better understanding.

The script works fine. 👍🏻
Good work.

@AdityaJ7 AdityaJ7 requested a review from tusharnankani October 1, 2020 09:56
Copy link
Member

@chavarera chavarera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is working fine

Suggestions
Add Helper functions instead if writing statement by statement
A helper function is a function that performs part of the computation of another function. Helper functions are used to make your programs easier to read by giving descriptive names to computations. They also let you reuse computations, just as with functions in general.

@mendoza mendoza requested a review from chavarera October 1, 2020 13:25
@AdityaJ7 AdityaJ7 requested review from tusharnankani and removed request for chavarera October 1, 2020 13:26
@mendoza
Copy link
Author

mendoza commented Oct 1, 2020

Is something missing?

@mergify mergify bot merged commit f85d2e8 into Python-World:master Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert JSON to YAML
4 participants