Skip to content

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Jan 21, 2025

Two breaking changes:

  • Remove the sync APIs. Callers need to update from the sync_ version to the fully async_ version. These APIs currenty log warnings when not called from an async when an event loop is not started.
  • These APIs will now log when the client library is not shutdown properly. The caller must call the async release methods when shutting down to free any resources rather than relying on the __del__ method which is not async. This is logged at debug since i'm not sure how reliable it is to check "is_connected"

Issue #228

@humbertogontijo humbertogontijo merged commit 3c30d93 into Python-roborock:main Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants