fix: remove the __del__ warning for disconnected clients #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenporter
changed the title
|
Failing tests? Not sure if it's just a stubborn test |
Lash-L
approved these changes
Jan 26, 2025
|
It appears that some tests are flaky, darn. I'll try to see if i can reproduce and take a look. Maybe faking the sockets and/or using the real threads is too complex, or maybe its spotting a real issue with how we're using the mqtt client, I can't tell yet. |
|
(Re-running the test and it passed so i think its flaky) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had some problems in home assistants unit test. I think it is reasonable to just require clients to shut down things properly and not have this.
This is needed to update python-roborock in Home Assistant.