Skip to content

feat: add the ability to update supported_features via cli #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 21, 2025

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Aug 9, 2025

Heavily AI assisted

I kept the information like "Feature Info", etc in the table so that in the future, when we added more features, we can recacluate it for all devices.

@Lash-L Lash-L requested a review from allenporter August 9, 2025 17:37
allenporter
allenporter previously approved these changes Aug 10, 2025
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. I assume we'll want to be able to collect these from multiple people and re-generate the table (e.g. you and i have different devices so we can't merge them). As a future step would we have a place in the repo we check them in that we can merge with new devices then generate the markdown from that?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Aug 10, 2025

Very cool. I assume we'll want to be able to collect these from multiple people and re-generate the table (e.g. you and i have different devices so we can't merge them). As a future step would we have a place in the repo we check them in that we can merge with new devices then generate the markdown from that?

Definitely a good thing to add. Right now if you do it from within the repo, it will automatically update the existing one.

But some way to merge should be fairly trivial and would be helpful so people don't have to clone and commit to give the info.

I also store the featureinfo so that if we get new features to evaluate, we can re evaluate all of them at once

@Lash-L
Copy link
Collaborator Author

Lash-L commented Aug 10, 2025

Changed this to put the features in a yaml file so that it is easier to update.

@Lash-L Lash-L requested a review from allenporter August 10, 2025 15:59
@allenporter allenporter merged commit 41d5433 into main Aug 21, 2025
6 checks passed
@allenporter
Copy link
Contributor

This is great, i think we can totally follow this pattern to capture more data to improve test data as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants