fix: change e2 fan codes #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humbertogontijo
approved these changes
May 27, 2023
|
@humbertogontijo I was out of town for a bit but now I'm trying to make some progress on some things. Any idea what is going on with the disconnects people are having with the map? Also are there any bugs with the current version of the api? I'm on 17.0 on core. Particularly just any bugs with local connection. Want to know before I bump it |
|
I did some work with the local api adding a ping method that runs in the background every 10 seconds to avoid disconnection on actual commands(it could be the reason of lots of reconnections, I think we can just change the logs to ignore it for the ping command) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #327