Mariya Polyakova #44
Open
Mariya Polyakova #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for visual indent corrected, function which deletes whitespaces added.
dzhigailo
reviewed
Jun 10, 2019
|
|
||
|
|
||
| def is_operand(token): | ||
| if token.isdigit() or is_float(token): |
There was a problem hiding this comment.
Можно просто сделать return token.isdigit() or is_float(token)
dzhigailo
reviewed
Jun 10, 2019
| func_name, func_attr_count = decode_func_attr_count(token) | ||
| while func_attr_count > 0: | ||
| if not stack: | ||
| raise Exception("missing argument") |
There was a problem hiding this comment.
Можно создавать кастомные исключения. Такой подход делает код более читаемым
|
|
||
| def is_token_basic_operator(token): | ||
| exceptions = [')'] | ||
| if token in exceptions: |
There was a problem hiding this comment.
Функция выглядит довольно странно. Какой смысл создавать список из одного значения и проверять входит ли аргумент в этот список? Не проще ли просто сравнить?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the final version of the code