Add Python 3.5 support #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daenyth
reviewed
Oct 26, 2016
tests/test_future/test_bytes.py
Outdated
| def test_mod(self): | ||
| """ | ||
| From Py3.5 test suite (post-PEP 461). | ||
|
|
||
| The bytes mod code is in _PyBytes_Format() in bytesobject.c in Py3.5. | ||
| """ | ||
| if sys.version_info[:2] < (3, 5): | ||
| raise unittest.SkipTest('bytes % not yet implemented on Py < 3.5') |
There was a problem hiding this comment.
You could also do @unittest.skipIf(bool, msg)
|
You could add Python 3.6 as well as it has since been released. |
|
Pull request #300 also tries to add 3.5 in addition to 3.6, etc. |
Fixed unit tests fail on Python 3.5 Added Python 3.5/3.6 in Travis CI Mark Python 3.6 as supported in setup.py
|
Can you rebase please to bring the latest TravisCI infra fixes in, and get this working? |
|
all changes already in master. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unit tests fail on Python 3.5
Added Python 3.5 in Travis CI
Mark Python 3.5 as supported in setup.py