Week1 polishes #11
Merged
Week1 polishes #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yammesicka
reviewed
Apr 14, 2019
| @@ -352,7 +352,7 @@ | |||
| "source": [ | |||
| "<p style=\"text-align: right; direction: rtl; float: right;\">\n", | |||
| "קניתי 5 ארגזים גדולים של קרמבו. בארגז יש 10 קרמבו בכל שורה, ו־4 קרמבו בכל עמודה.<br>\n", | |||
| "נסו לשים כל אחד מהנתונים שמצאתם בשאלה במשתנה, ולהדפיס את התשובה הנכונה.\n", | |||
| "נסו לשים כל אחד מהנתונים שמצאתם בשאלה במשתנה, ולהדפיס כמה קרמבו יש לי.\n", | |||
There was a problem hiding this comment.
Excellent. I usually fix myself when talking in general instead of mentioning specifics, but it's hard to find it all.
yammesicka
requested changes
Apr 14, 2019
week1/1_Strings_and_Output.ipynb
Outdated
| @@ -213,7 +213,7 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "print('\"Why were you lurking under our window?\" \"Yes - yes, good point, Petunia! What were you doing under our windows, boy?\" \"Listening to the news,\" said Harry in a resigned voice. His aunt and uncle exchanged looks of outrage. \"Listening to the news! Again?\" \"Well, it changes every day, you see,\" said Harry.')" | |||
| "print('\"Listening to the news,\" said Harry in a resigned voice. His aunt and uncle exchanged looks of outrage. \"Listening to the news! Again?\" \"Well, it changes every day, you see,\" said Harry.')" | |||
There was a problem hiding this comment.
I think the long example (and the buildup) adds some value.
Would you please rollback this specific change? All the others are terrific.
This reverts commit d83c503.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly minor typo / word changes.