-
Notifications
You must be signed in to change notification settings - Fork 52
feat: adding holidays to calendar as events #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I've added few of my insights :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested only a minor fix. Please add type annotations to your functions and we're good to go :)
# Conflicts: # app/routers/profile.py # app/templates/profile.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! I've added few additional comments :)
# Conflicts: # app/routers/profile.py
Codecov Report
@@ Coverage Diff @@
## develop #165 +/- ##
===========================================
- Coverage 99.38% 99.02% -0.36%
===========================================
Files 46 46
Lines 2101 2146 +45
===========================================
+ Hits 2088 2125 +37
- Misses 13 21 +8
Continue to review full report at Codecov.
|
# Conflicts: # app/templates/profile.html
Hi @yammesicka - just found out that in latest version I'm having weird issues - when trying to add the file and import I'm getting: Edit - found the solution - i pushed it to extending_openapi as this branch already been marged |
https://forums.pythonic.guru/t/topic/8637
Added an option for user to import holidays from ics file.
Took the naïve approach for now - not checking for duplicates while importing.
Need to think about this mechanism - since checking every date to see if holiday is there is too expensive.
As for the first step i think its ok (: