Skip to content

Conversation

nir9696
Copy link
Contributor

@nir9696 nir9696 commented Feb 1, 2021

No description provided.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the build work :) It's probably the deletion of the content from requirements.txt

@nir9696
Copy link
Contributor Author

nir9696 commented Feb 9, 2021

There is a recurring problem with "datetime" detection in event.py. At first I saw the source of the error - using the "dt" alias, but now there is no such alias, so the error is not clear to me. I saw that others also encountered this error. Can you please take a look?

@yammesicka
Copy link
Member

There is a recurring problem with "datetime" detection in event.py. At first I saw the source of the error - using the "dt" alias, but now there is no such alias, so the error is not clear to me. I saw that others also encountered this error. Can you please take a look?

Try to pull from develop, I believe

@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #178 (49a77b6) into develop (8cd3a6e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #178   +/-   ##
========================================
  Coverage    99.04%   99.04%           
========================================
  Files           52       52           
  Lines         2409     2409           
========================================
  Hits          2386     2386           
  Misses          23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cd3a6e...49a77b6. Read the comment docs.

@nir9696 nir9696 requested a review from yammesicka February 12, 2021 09:36
@nir9696 nir9696 requested a review from yammesicka February 13, 2021 19:32
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done :)

@nir9696 nir9696 requested a review from yammesicka February 14, 2021 05:23
@nir9696 nir9696 requested a review from yammesicka February 15, 2021 15:51
@yammesicka yammesicka merged commit fe7b021 into PythonFreeCourse:develop Feb 15, 2021
@OdeYec
Copy link
Collaborator

OdeYec commented Feb 16, 2021

Hi, some hindsight notes: notice that in edit_event_details_tab.html you are using multiple id tags with the same values that is bad practice (there should be only one element with the same id tag per page) + you have div elements without closing tags which breaks the layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants