-
Notifications
You must be signed in to change notification settings - Fork 52
Feature/add githooks #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yammesicka
merged 18 commits into
PythonFreeCourse:develop
from
annashtirberg:feature/add_githooks
Feb 11, 2021
Merged
Feature/add githooks #224
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a944545
Test flake hook
annashtirberg cf69d19
Initial pre-commit hooks, runs flake8 and if it fails don't commit. a…
annashtirberg 794acdb
Initial pre-commit hooks, runs flake8 and if it fails don't commit. a…
annashtirberg dd1a4b8
Removed temporary file
annashtirberg 1af8ecf
Merge branch 'develop' of https://github.com/PythonFreeCourse/calenda…
annashtirberg 9004f3f
Improved README.md
annashtirberg 4e1009c
Merge branch 'develop' of https://github.com/PythonFreeCourse/calenda…
annashtirberg 0285ac3
testing
annashtirberg d596cc2
Testing
annashtirberg e21d80f
Added some hook explanations
annashtirberg d5378e4
Merge branch 'develop' of https://github.com/PythonFreeCourse/calenda…
annashtirberg bf486d9
Fixed import error
annashtirberg 5a5eedd
Reverted event changes
annashtirberg 282edc8
Merge branch 'develop' of https://github.com/PythonFreeCourse/calenda…
annashtirberg dd330ae
Improved the README.md
annashtirberg 36438cb
Merge branch 'develop' of https://github.com/PythonFreeCourse/calenda…
annashtirberg 9533f32
Added requirements.txt
annashtirberg 423fb5f
Added requirements.txt
annashtirberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| repos: | ||
| # Flake8 to check style is OK | ||
| - repo: https://gitlab.com/pycqa/flake8 | ||
| rev: 3.8.4 | ||
| hooks: | ||
| - id: flake8 | ||
| # yapf to fix many style mistakes | ||
| - repo: https://github.com/pre-commit/mirrors-yapf | ||
| rev: v0.30.0 | ||
| hooks: | ||
| - id: yapf | ||
| name: yapf | ||
| language: python | ||
| entry: yapf | ||
| args: [-i, -vv] | ||
| types: [python] | ||
| # More built in style checks and fixes | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v3.2.0 | ||
| hooks: | ||
| - id: trailing-whitespace | ||
| - id: check-docstring-first | ||
| - id: check-json | ||
| - id: check-added-large-files | ||
| - id: check-yaml | ||
| - id: debug-statements | ||
| - id: requirements-txt-fixer | ||
| - id: check-merge-conflict | ||
| - id: double-quote-string-fixer | ||
| - id: end-of-file-fixer | ||
| - id: sort-simple-yaml | ||
| - repo: meta | ||
| hooks: | ||
| - id: check-useless-excludes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment doesn't work on my shell. Maybe it requires some another prerequisite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it and I think it will work for you (and everyone else too) now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I change it, ok now it is correct
you need to install the requirements before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you've changed the requirements.txt and forgot to push it?
Currently I don't have anything in the requirements.txt that installs the
pre-commitcommand, unfortunately :(There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh no, your right, my mistake
I fixed it now