Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exercise #227

Open
wants to merge 86 commits into
base: develop
Choose a base branch
from

Conversation

orontamir
Copy link

Create new freature

in feature page , cliking on "Start Exercise" and in "Exercixe" tab you can see exercise plane each day for 30 days

@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #227 (ec126c3) into develop (5c2136b) will decrease coverage by 0.57%.
The diff coverage is 60.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #227      +/-   ##
===========================================
- Coverage    94.43%   93.85%   -0.58%     
===========================================
  Files           91       93       +2     
  Lines         4257     4329      +72     
===========================================
+ Hits          4020     4063      +43     
- Misses         237      266      +29     
Impacted Files Coverage Δ
app/main.py 96.00% <ø> (ø)
app/routers/profile.py 85.60% <35.29%> (-7.44%) ⬇️
app/routers/exercise.py 50.00% <50.00%> (ø)
app/routers/user_exercise.py 72.41% <72.41%> (ø)
app/database/models.py 97.51% <100.00%> (+0.04%) ⬆️
app/routers/event.py 95.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2136b...ec126c3. Read the comment docs.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good start :) I've added few of my insights, please take a look.

app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/routers/profile.py Outdated Show resolved Hide resolved
app/routers/profile.py Outdated Show resolved Hide resolved
app/routers/profile.py Outdated Show resolved Hide resolved
app/routers/profile.py Outdated Show resolved Hide resolved
app/routers/user_exercise.py Outdated Show resolved Hide resolved
tests/test_a_telegram_asyncio.py Outdated Show resolved Hide resolved
@yammesicka
Copy link
Member

That's an option, but why not go for an easier one? :)

Just Google workout plan open source and find something that provided as-is with a free license.

@orontamir
Copy link
Author

Hi Yam

I found an application with a free license.

https://veevapps.wordpress.com/2017/04/20/lose-weight-in-30-days-privacy-policy/

Hopefully now I can finish my task :) 👍

@orontamir
Copy link
Author

Hi Yam

I corresponded with the writer , Vera Mo, veevapps@gmail.com, and he gave me permission to create screenshot from his application.

VeraMo

Hopefully now you can approve my pull request.

Thanks

Oron

@yammesicka
Copy link
Member

yammesicka commented Feb 18, 2021

Please let them know you are going to integrate it into another application.
This is an important disclaimer which can affect the licensing.

Here is the letter you should send:

Dear Veev Apps,

For the past month I have been working on an open source calendar project.
I wanted to know if I could use content from your app (pictures and text of the exercises) and incorporate it into the calendar, in a way that everyone could use.
The project is published under the Apache2 license.
Here is a link to the project: https://github.com/PythonFreeCourse/calendar

Best Regards,
Oron

@orontamir
Copy link
Author

Hi
I send them an email , waiting for them response

Thanks

Oron

@orontamir
Copy link
Author

Hi Yam

Veev answer me . I cannot use pictures and text of exercises.

I move to the next solution . write exercises by my self.

Thanks

Oron

@orontamir
Copy link
Author

Hi Yam

Since I did not find any open source with exercises , I wrote 30 exercise by my self with som help from gym instructor.

I wrote it in word and convert to HTM files.

Insted of "How to do..." I just add link to YouTube (I do not need license to publish).

Please let me know if its OK with you.

Thanks

Oron

@yammesicka
Copy link
Member

That's OK Oron.
I appreciate your devotion to the goal.

From my side, you have finished the work on this ticket - it is considered a ticket for the certificate.
If you want to complete it for yourself - feel free to continue.

@orontamir
Copy link
Author

Hi Yam

Thanks a lot for your suppoer 👍

I really enjoyed learning from you python

Oron

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #227 (507fb2e) into develop (2730ecf) will decrease coverage by 0.55%.
The diff coverage is 60.27%.

❗ Current head 507fb2e differs from pull request most recent head 6f784b5. Consider uploading reports for the commit 6f784b5 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #227      +/-   ##
===========================================
- Coverage    93.95%   93.40%   -0.56%     
===========================================
  Files           93       95       +2     
  Lines         4383     4455      +72     
===========================================
+ Hits          4118     4161      +43     
- Misses         265      294      +29     
Impacted Files Coverage Δ
app/main.py 96.07% <ø> (ø)
app/routers/profile.py 85.60% <35.29%> (-7.44%) ⬇️
app/routers/exercise.py 50.00% <50.00%> (ø)
app/routers/user_exercise.py 72.41% <72.41%> (ø)
app/database/models.py 97.29% <100.00%> (+0.04%) ⬆️
app/routers/event.py 95.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2730ecf...6f784b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants