feat: change owner of event #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #268 +/- ##
========================================
Coverage 99.04% 99.05%
========================================
Files 52 52
Lines 2409 2425 +16
========================================
+ Hits 2386 2402 +16
Misses 23 23
Continue to review full report at Codecov.
|
yammesicka
requested changes
Feb 14, 2021
app/routers/event.py
Outdated
| async def changeowner(request: Request, event_id: int, | ||
| db: Session = Depends(get_db)): | ||
| data = await request.form() | ||
| if 'username' in data: |
There was a problem hiding this comment.
Prefer if 'username' not in form: return [...] and the rest of the code unindented
app/routers/event.py
Outdated
| @router.post("/{event_id}") | ||
| async def changeowner(request: Request, event_id: int, | ||
| db: Session = Depends(get_db)): | ||
| data = await request.form() |
There was a problem hiding this comment.
Prefer a better name, form for example
app/templates/base.html
Outdated
| </li> | ||
| <li class="nav-item"> | ||
| <!-- new button for the agenda page. should be available after login | ||
| <div class="collapse navbar-collapse" id="navbarText"> |
There was a problem hiding this comment.
Return this to be indentation of 2 spaces
app/templates/profile.html
Outdated
| @@ -1,338 +1,316 @@ | |||
| {% extends "base.html" %} {% include "event/partials/text_editor_partial_head.html" %} {% block content %} | |||
|
|
|||
| <div class="container mt-4"> | |||
| <div class="container mt-4"> | |||
yammesicka
requested changes
Feb 15, 2021
app/routers/event.py
Outdated
| @@ -97,6 +97,31 @@ async def eventview(request: Request, event_id: int, | |||
| "messages": messages}) | |||
|
|
|||
|
|
|||
| @router.post("/{event_id}/owner_changed") | |||
There was a problem hiding this comment.
Just /owner is good enough :)
app/routers/event.py
Outdated
| @@ -97,6 +97,31 @@ async def eventview(request: Request, event_id: int, | |||
| "messages": messages}) | |||
|
|
|||
|
|
|||
| @router.post("/{event_id}/owner_changed") | |||
| async def changeowner(request: Request, event_id: int, | |||
| </div> | ||
| <div class="event_info_row"> | ||
| <span class="icon">ICON</span> | ||
| <time datetime="{{ event.start }}">{{ event.start.strftime(start_format )}}</time> | ||
| - | ||
| <time datetime="{{ event.start }}">{{ event.start.strftime(start_format )}}</time> - |
yammesicka
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change owner of an event