Feature/todo list #285
Feature/todo list #285
Conversation
… and add some functions
Codecov Report
@@ Coverage Diff @@
## develop #285 +/- ##
===========================================
+ Coverage 94.54% 94.57% +0.03%
===========================================
Files 85 87 +2
Lines 3997 4076 +79
===========================================
+ Hits 3779 3855 +76
- Misses 218 221 +3
Continue to review full report at Codecov.
|
app/internal/todo_list.py
Outdated
| return task | ||
|
|
||
|
|
||
| def sort_by_time(tasks: List[Task]) -> List[Task]: |
There was a problem hiding this comment.
Prefer sorting in the database, it's probably faster
There was a problem hiding this comment.
But the most logical thing to do is to sort your daily task by the time they happen
There was a problem hiding this comment.
You're right - I meant to order them when you querying the database using sort by
… and fixed styles
…ed edit task test and reformatted
app/routers/dayview.py
Outdated
| tasks = (session.query(Task) | ||
| .filter(Task.owner_id == user.user_id) | ||
| .filter(Task.date == day.date()) | ||
| .order_by(Task.time) | ||
| ) |
There was a problem hiding this comment.
Please use precommit hooks to reformat
app/routers/todo_list.py
Outdated
| status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, | ||
| ) | ||
| return RedirectResponse( | ||
| url=f"/day/{date_str}", |
There was a problem hiding this comment.
Use url_for on all those places
app/static/js/todo_list_modals.js
Outdated
|
|
||
| function openEditModal(event){ | ||
| const modal = document.getElementById('edit-modal'); | ||
| console.log(event); |
| data-bs-dismiss="modal" | ||
| aria-label="Close"></button> | ||
| </div> | ||
| <form action="/task/edit" method="post"> |
There was a problem hiding this comment.
Use url_for wherever relevant
tests/test_todo_list.py
Outdated
|
|
||
| def test_if_task_deleted(home_test_client, task1: Task, session): | ||
| response = home_test_client.post( | ||
| "/task/delete", |
app/static/js/todo_list_modals.js
Outdated
| //function openEditModal(taskId, taskTime, taskTitle, taskDescription, taskImportant){ | ||
| // $('#list-modal').modal('toggle'); | ||
| // $('#edit-task-id').val(taskId); | ||
| // $('#customer-time2').val(taskTime); | ||
| // $('#customer-title2').val(taskTitle); | ||
| // $('#customer-descrip2').val(taskDescription); | ||
| // $('#is-important2').prop('checked', taskImportant); | ||
| // $('#edit-modal').modal('toggle'); | ||
| //} |
I created a tasks list for every day in
dayviewby clicking on the buttoncreate taskyou can add task to the daily tasks list.by clicking on the button
todo listyou can see all your daily tasks sorted by time and marked by important or not.after you finish a task you can mark the task
Done.