Skip to content

Support Filter by Categories #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 23, 2021
Merged

Support Filter by Categories #298

merged 14 commits into from
Feb 23, 2021

Conversation

ivarshav
Copy link
Contributor

Allow filtering events in agenda view by categories.
Right now, only filter by category id is available.
In next fase, filter by category name will be supported.

#67

Demo:
image

@ivarshav ivarshav changed the title Support by Categories Support Filter by Categories Feb 15, 2021
This was referenced Feb 17, 2021
Closed
Merged
@codecov-io
Copy link

codecov-io commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #298 (51c3643) into develop (2176d5f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #298   +/-   ##
========================================
  Coverage    95.83%   95.83%           
========================================
  Files           75       75           
  Lines         3358     3363    +5     
========================================
+ Hits          3218     3223    +5     
  Misses         140      140
Impacted Files Coverage Δ
app/routers/agenda.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2176d5f...51c3643. Read the comment docs.

yammesicka
yammesicka requested changes Feb 18, 2021
View reviewed changes
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job! I've added few insights :)

app/static/js/categories_filter.js Outdated
@@ -0,0 +1,31 @@
function filterByCategory(events) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! JS Ninja

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

yammesicka
yammesicka reviewed Feb 20, 2021
View reviewed changes
@ivarshav
Update agenda_style.css
4b505f1 
change px to em
@ivarshav ivarshav requested a review from yammesicka February 20, 2021 17:55
yammesicka
yammesicka requested changes Feb 21, 2021
View reviewed changes
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've added few additional notes, mainly about the dynamic edit of the CSS

@ivarshav ivarshav requested a review from yammesicka February 21, 2021 10:56
@yammesicka yammesicka merged commit f01371f into PythonFreeCourse:develop Feb 23, 2021
@ivarshav ivarshav mentioned this pull request Feb 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yammesicka yammesicka yammesicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivarshav @codecov-io @yammesicka