Skip to content

feat: Support uploading images #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2020
Merged

feat: Support uploading images #252

merged 4 commits into from
Oct 16, 2020

Conversation

orronai
Copy link
Collaborator

@orronai orronai commented Oct 16, 2020

  • Images will be now shown as real images and not as binary text
  • Added a test
  • Changed a bit the frontend for supporting images

@orronai
feat: Support uploading images
d6e51e2 
- Images will be now shown as real images and not as binary text
- Added a test
- Changed a bit the frontend for supporting images
@orronai orronai linked an issue Oct 16, 2020 that may be closed by this pull request
Add support for uploading images #250
Closed
2 tasks
@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #252 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   78.76%   79.03%   +0.27%     
==========================================
  Files          54       55       +1     
  Lines        2303     2333      +30     
==========================================
+ Hits         1814     1844      +30     
  Misses        489      489
Impacted Files Coverage Δ
lms/extractors/imagefile.py 100.00% <100.00%> (ø)
lms/extractors/ziparchive.py 97.22% <100.00%> (+0.16%) ⬆️
lms/models/solutions.py 98.94% <100.00%> (+0.01%) ⬆️
lms/utils/files.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a6ab5...103dba2. Read the comment docs.

yammesicka
yammesicka requested changes Oct 16, 2020
View reviewed changes
yammesicka
yammesicka reviewed Oct 16, 2020
View reviewed changes
@yammesicka yammesicka merged commit 11a67a3 into master Oct 16, 2020
@yammesicka yammesicka deleted the allow-uploading-images branch October 16, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yammesicka yammesicka yammesicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for uploading images
2 participants
@orronai @yammesicka