Skip to content

[MRG] Add assert for emd dimension mismatch #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2020
Merged

[MRG] Add assert for emd dimension mismatch #116

merged 5 commits into from
Jan 20, 2020

Conversation

kilianFatras
Copy link
Contributor

Hello,

I am sending a PR with a patch to issue 114. In this PR, you will find:

. An assert condition (M dimensions with a and b)
. Test to catch the Assertion error.

@rflamary rflamary changed the title [WIP] Add assert for emd dimension mismatch [MRG] Add assert for emd dimension mismatch Dec 19, 2019
@rflamary rflamary changed the title [MRG] Add assert for emd dimension mismatch [WIP] Add assert for emd dimension mismatch Dec 19, 2019
@rflamary
Copy link
Collaborator

rflamary commented Jan 7, 2020

Hello @kilianFatras,

I'm ok with the PR but you need to resolve the conflict that appeared wrt the master branche before merge.

@rflamary rflamary changed the title [WIP] Add assert for emd dimension mismatch [MRG] Add assert for emd dimension mismatch Jan 20, 2020
@rflamary rflamary merged commit 1b58440 into PythonOT:master Jan 20, 2020
@rflamary rflamary mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hichamjanati hichamjanati hichamjanati approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilianFatras @rflamary @hichamjanati