[MRG] build wheels on release #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rflamary
commented
Apr 22, 2020
rflamary
commented
- build automatically wheels on release
- hopefully for manylinux/windows/macosx
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 15 15
Lines 3023 3023
=======================================
Hits 2750 2750
Misses 273 273 |
agramfort
reviewed
Apr 22, 2020
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| pip install -U "cython" | ||
|
|
There was a problem hiding this comment.
Why is cython not in requirements ?
There was a problem hiding this comment.
it is!
but the build fails if i dont' do that... This is weird.
agramfort
reviewed
Apr 23, 2020
Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.