[MRG] Wasserstein convolutional barycenter #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pep8 fixed (contd)
rflamary
reviewed
Sep 7, 2018
There was a problem hiding this comment.
Thank you @ncourty,
This is very nice. I have a few comments below but we will also need a test for the new function (check that the barycenter sum to one for instance) and there are still a few pep8 problems.
you can use autopep8 if install with
make aautopep8
the double a is not a typo will do a force and add new lines if necessary
README.md
Outdated
| [20] Cuturi, M. and Doucet, A. (2014) [Fast Computation of Wasserstein Barycenters](http://proceedings.mlr.press/v32/cuturi14.html). International Conference in Machine Learning |
There was a problem hiding this comment.
Branch in conflict with master,
stabThr and pep8
whitetrail pep8
test wasserstein barycenter
rflamary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.