Skip to content

Bug Greenkhorn with log=True #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2019
Merged

Bug Greenkhorn with log=True #76

merged 2 commits into from
Mar 11, 2019

Conversation

rflamary
Copy link
Collaborator

This PR adresses the bug reported in Issue #75.

What has been done:

  • Add a test that check with log=True works for all sinkhorn variants
  • Correct the bug Possible bugs in greenkhorn algorithm #75 in greenkhorn
  • Add conversion to np.array inside greenkhorn (same as sinkhorn now)

@rflamary rflamary changed the title Bug Greenkhorn+log=True Bug Greenkhorn with log=True Mar 11, 2019
@rflamary rflamary mentioned this pull request Mar 11, 2019
Closed
@rflamary rflamary merged commit e757b75 into master Mar 11, 2019
@rflamary rflamary deleted the bug_log_greenkhorn branch June 27, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rflamary