[WIP] Add stabilization for the unbalanced module #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamjanati
changed the title
|
Ew .. this was not over. |
|
Sorry mistake on my part i guess, I wanted to merge PR #97, but this one became merged? I really only merge the other I dont know what happened. Please do another PR indeed ;) |
|
OK this is because you merged your other PR in #97. Next time let me merge the small stuff into master before merging between you PR and this will not happen. |
|
Agh right, my bad. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #87 by adding:
bregman.pysinkhorn_stabilized_unbalancedto compute the unbalanced optimal cost / transport plan with log stabilization.barycenter_unbalanced_logto compute the unbalanced barycenter in log-domain with logsumexp operations.I am also thinking when a numerical error is encountered, Instead of stopping and returning the previous value, we could automatically switch to log-domain, what do you think ?