-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important modifications to be applied to Workshop 2 #7
Comments
Additional issues to be addressed (added Feb 2021)Both presentations
English presentation
French presentation
|
I have updated the badges in the french presentation and will do the same in the english pres on my branch otherwise decated to improving the french presentation val-french-pres. Please take note @YeonseonJeon |
Cant find the overflow in slides 83, 84, 87, 89. Slide 94 has a small overflow o the roght which I fixed. @linley-sherin can you explain what you mena by overflow on slides 83, 84, 87, 89? I dont see it. |
Hi Valentin! I can't find the overflow now either, I checked previous commits and don't see where it was fixed. I am not sure what happened there but I will run through the issues listed above right now and edit so that the list is accurate. Thank you for checking in. |
The issue list is updated now. I added a note that you can modify either the French or English slides to match each other because I noticed when I was looking through that sometimes the French slides had more text which you might want to keep. You can use your discretion in those instances. Feel free to check in with us at any point if you two are confused or need a 3rd opinion. Thanks! |
Before developing and modifying this workshop, please read through the presenter and developer protocol carefully and refer back to it regularly as you work.
General issues to be addressed
Specific to adapting workshops to a remote framework:
instruction: hidden_remote
tag. See an example below:Specific to slide structure, grammar and style
Ensure code is working correctly and that code matches workshop presentation. Continue to check this as you make changes.
Proofread correcting spelling, grammar, or punctuation errors.
Look for and correct the content of slides that overflow the screen.
Look for and correct prose that mentions function names, object names, package names and code chunks that do not use backticks.
Look for and correct unnecessary abbreviations (e.g. use do not instead of don’t).
Correct unnecessary long sentences.
Ensure that the slides are written in a consistent style, which helps with the flow of workshops and student understanding. This is especially important when working collaboratively with other developers.
Include presenter notes to the slides you modify. You can write notes for yourself to read in the presenter mode (press the keyboard shortcut
p
). These notes are written under three question marks???
. See the example below:Specific to the translation of this workshop
Add and translate the modified content to the French version of the workshop.
Proofread and correct spelling, grammar and punctuation errors.
Correct unnecessary long sentences.
Specific to this workshop
dplyr
,tidyr
, andmaggritr
) as something for "advanced users" makes these tools seem less accessible, when that is not necessarily the case. This also breaks the workshop structure's logic, and makes this section seem separate from the rest of the workshop. In an effort to make this section less intimidating, it would be better to change this wording to focus on making the distinction between base R and thetidyverse
sections of the workshop. Specifically, it can be important to briefly explain the contributions of thetidy
packages (i.e. why usedplyr
when most operations can be done in base R). This would help clarify the workshop structure, and would also be a great opportunity to make a fun "Welcome to the tidyverse" slide to introduce the tidy content 🤩.gather()
andspread()
occurrences topivot_wider()
andpivot_longer()
, becausegather()
andspread()
are now retired. Argument names will also need to be changed (key
andvalue
have been replaced).dplyr
logo here,tidyr
logo here).header = T
toheader = TRUE
, because usingT
is not recommended.tibble
structure in thetidyverse
section.Only close this issue after all cases have been ticked and verified.
The text was updated successfully, but these errors were encountered: