[Requires Testing] Add label to reach point #219
Conversation
|
Same idea as in #212, but I changed the branch name, which closed the other PR. |
solves stack overflow, trigger functionality pending
|
Current status: trigger functions are working, but triggers themselves are not set yet |
|
CI says : https://github.com/QGEP/datamodel/actions/runs/5948505152/job/16132413018?pr=219#step:15:7166 Applying delta 1.6.1 update_rp_label... dict is not a sequence |
|
What is striking me in this WIP is the time taken by the CI Check. There might be an infinite loop |
Have you tried it on a real database or demo-data? |
From Alpha testing, there was an _all substituted
Text compares lead to performance issues, so the function now uses arrays of feasible ws_status and ch_function_hierarchic. Added benefit that they can be overriden
|
@ponceta @sjib all labels are now stored in Also I didn't check if there are functions (i.e. export functions) referencing |
|
This is now a clear evolution feature and requires a good testing on real data sets. To be checked also if the Interlis Import/Export would be adapted. And tested in terms of performance. |
|
I also would suggest to check performance carefully
|
|
I agree. I suggest that the PR will not be merged into release 1.6.1 To do:
If @sjib and @ponceta agree on thie procedure, I would close the PR for the qgep datamodel |
Prioritise main wastewater node for reach point label
add a "Select"
Comments were different...
add a linebreak
Copying from symbology functions
| COMMENT ON COLUMN qgep_od.wastewater_structure._bottom_label IS 'stores the bottom altitude to be used for labelling, not part of the VSA-DSS data model | ||
| added solely for QGEP'; | ||
|
|
||
| added solely for TEKSI wastewater'; | ||
|
|
||
| -- this column is an extension to the VSA data model and puts the _function_hierarchic in order | ||
| ALTER TABLE qgep_vl.channel_function_hierarchic ADD COLUMN order_fct_hierarchic smallint; |
There was a problem hiding this comment.
https://github.com/teksi/Home/wiki/TEKSI-Developer-Guide#custom-fields
Does this also need an underscore _order_fct_hierarchic ?
There was a problem hiding this comment.
Imho no. It is not dependent of another table.
In the logic of #219 (comment) it would be x_order_fct_hierarchic
05_data_model_extensions.sql
Outdated
| @@ -51,6 +35,15 @@ UPDATE qgep_vl.channel_function_hierarchic SET order_fct_hierarchic=12 WHERE cod | |||
| UPDATE qgep_vl.channel_function_hierarchic SET order_fct_hierarchic=11 WHERE code=5074; | |||
| UPDATE qgep_vl.channel_function_hierarchic SET order_fct_hierarchic=14 WHERE code=5075; | |||
|
|
|||
| -- this column is an extension to the VSA data model and defines whether connected channels are included in inflow/outflow labeling based on function_hierarchic | |||
| ALTER TABLE qgep_vl.channel_function_hierarchic ADD COLUMN include_in_ws_labels boolean DEFAULT FALSE; | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Is a custom field usr_xxx not equal to a db extension by a single user (not included in github and pum)
There was a problem hiding this comment.
For me it is not totally clear if we have (here)
a) calculated fields -> _ would need an underscore
b) custom field -> usr_xxx
c) something new - an additional TEKSI needed field, that is not part of VSA-DSS but not realy "calculated" and
d) do we distinguish if this is done in a view of the model or in the view of the project
There was a problem hiding this comment.
For me it is c)
A Teksi-specific extension independent of other tables. My suggestion is to prefix these cases x_ (eXtension).
05_data_model_extensions.sql
Outdated
|
|
||
|
|
||
| -- this column is an extension to the VSA data model and defines whether connected channels are included in inflow/outflow labeling based on function_hierarchic | ||
| ALTER TABLE qgep_vl.wastewater_structure_status ADD COLUMN include_in_ws_labels boolean DEFAULT FALSE; |
There was a problem hiding this comment.
There was a problem hiding this comment.
In the logic of #219 (comment) it would be x_include_in_ws_labels. Not a custom field (this one shouldnt be excluded from pum)
05_data_model_extensions.sql
Outdated
| has to be updated by triggers'; | ||
|
|
||
| -- label extensions | ||
| CREATE TABLE IF NOT EXISTS qgep_od.labels |
There was a problem hiding this comment.
https://github.com/teksi/Home/wiki/TEKSI-Developer-Guide#custom-fields
_labels instead of labels as it is not a VSA-DSS class
There was a problem hiding this comment.
_labels would be the field logic. We have no defined logic for extension tables.
Maybe we move it to qgep_sys?
cymed
changed the title
|
closing in favour of teksi/wastewater#85 |
In order to solve #9, a first step is to add a _label to reach point. The update procedure is entered in the update process of the wastewater structure labels. I tested the section for reach_points and for wastewater_structures separately, and they work. However, putting the code into one function as in the push probably causes recursions. Comments and ideas appreciated.