Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: "Docs and Tutorial / tutorials (3.7)" fails on PRs #1251

Closed
drewrisinger opened this issue May 11, 2021 · 2 comments · Fixed by #1252
Closed

CI: "Docs and Tutorial / tutorials (3.7)" fails on PRs #1251

drewrisinger opened this issue May 11, 2021 · 2 comments · Fixed by #1252
Labels
bug Something isn't working

Comments

@drewrisinger
Copy link
Contributor

drewrisinger commented May 11, 2021

Informations

  • Qiskit Aer version: main branch
  • Python version: 3.7
  • Operating system: CI: ubuntu-20.04

What is the current behavior?

On PR #1250, the "Docs and Tutorial / tutorials (3.7) (pull_request)" job is failing with the following error. It's unrelated to the contents of that PR.

2021-05-10T22:28:50.6161663Z sphinx-tabs 2.1.0 has requirement sphinx<4,>=2, but you have sphinx 4.0.1.

Suggested solutions

I guess the constraints for sphinx or sphinx-tabs will need to be tightened to prevent incompatible versions being installed.
This should be temporary, b/c sphinx-tabs has already been updated with support, and this pin could be removed on the next release. executablebooks/sphinx-tabs#110

@drewrisinger drewrisinger added the bug Something isn't working label May 11, 2021
@mtreinish
Copy link
Member

Ugh, yeah it looks like sphinx tabs is incompatible with the latest sphinx release. I think the short term workaround here is to just put a cap on sphinx in requirements-dev. The new pip depsolver should have been able to resolve this conflict, I'm not sure why it couldn't, but a manual pin should workd.

@mtreinish
Copy link
Member

Oh actually I was mistaken the issue is we're unnecessarily installing sphinx again in the tutorial job and that's ignoring the constraint from the already installed sphinx-tabs and causing pip check to fail at the end. That's even easier to fix.

mtreinish added a commit to mtreinish/qiskit-aer that referenced this issue May 11, 2021
This commit removes an unnecessary manual sphinx installation in the
tutorials CI job. This second install is causing a version to be
installed which is incompatible with already installed extensions. By
removing it this should hopefully enable pip's dependency solver to
resolve everything correctly and not cause incompatible versions from
being installed.

Fixes Qiskit#1251
chriseclectic pushed a commit that referenced this issue May 11, 2021
* Remove unnecessary duplicate sphinx installation

This commit removes an unnecessary manual sphinx installation in the
tutorials CI job. This second install is causing a version to be
installed which is incompatible with already installed extensions. By
removing it this should hopefully enable pip's dependency solver to
resolve everything correctly and not cause incompatible versions from
being installed.

Fixes #1251

* Increase test job timeout to 60min

The unit test jobs have been slowly encroaching on the configured
timeout for some jobs over time and we're now at a point where test jobs
regularly are hitting the timeout and failing. To avoid failures like
this from happening, this commit bumps the timeout for all the unittest
jobs to 60min which should give us a healthy margin for test suite
growth and random slow CI nodes without making us wait the full 6 hour
job limit in gha.
hitomitak pushed a commit to hitomitak/qiskit-aer that referenced this issue Jun 24, 2021
* Remove unnecessary duplicate sphinx installation

This commit removes an unnecessary manual sphinx installation in the
tutorials CI job. This second install is causing a version to be
installed which is incompatible with already installed extensions. By
removing it this should hopefully enable pip's dependency solver to
resolve everything correctly and not cause incompatible versions from
being installed.

Fixes Qiskit#1251

* Increase test job timeout to 60min

The unit test jobs have been slowly encroaching on the configured
timeout for some jobs over time and we're now at a point where test jobs
regularly are hitting the timeout and failing. To avoid failures like
this from happening, this commit bumps the timeout for all the unittest
jobs to 60min which should give us a healthy margin for test suite
growth and random slow CI nodes without making us wait the full 6 hour
job limit in gha.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants