CMake: Use built-in DL Lib variable #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses native CMake variable, instead of custom search mechanism. https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html
drewrisinger
force-pushed
the
dr-pr-fix-cmake-dl-libs
branch
from
880b01a
to
2bf04ad
Compare
vvilpas
approved these changes
May 12, 2021
10 tasks
hitomitak
pushed a commit
to hitomitak/qiskit-aer
that referenced
this pull request
Jun 24, 2021
Uses native CMake variable, instead of custom search mechanism. https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses the built-in CMake variable CMAKE_DL_LIBS, see https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html.
No new tests should be needed, I assume the Windows tests will test this.
Details and comments
Creating this PR to test against Windows CI, don't have a dev environment to test this change.