Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fake backend methods #1765

Merged
merged 14 commits into from
Jul 9, 2024
Merged

Add more fake backend methods #1765

merged 14 commits into from
Jul 9, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 20, 2024

Summary

Added the following methods to FakeBackendV2:

  • service unable to resolve circular dependencies with adding a service property
  • properties, defaults, configuration
  • status
  • check_faulty

Details and comments

Fixes #1605

@kt474 kt474 marked this pull request as ready for review June 25, 2024 17:39
@Qiskit Qiskit deleted a comment from coveralls Jun 25, 2024
@Qiskit Qiskit deleted a comment from coveralls Jun 25, 2024
@Qiskit Qiskit deleted a comment from coveralls Jun 25, 2024
@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9667616841

Details

  • 13 of 38 (34.21%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 81.735%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/fake_provider/fake_backend.py 13 38 34.21%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/utils/utils.py 1 61.27%
Totals Coverage Status
Change from base Build 9605113454: -0.3%
Covered Lines: 6086
Relevant Lines: 7446

💛 - Coveralls

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Jun 26, 2024
@kt474 kt474 added this to the 0.25.0 milestone Jun 27, 2024
@Qiskit Qiskit deleted a comment from coveralls Jul 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 81.935% (-0.3%) from 82.197%
when pulling 67e1038 on kt474:fake-backend-methods
into 5436f0f on Qiskit:main.

@kt474 kt474 requested a review from ptristan3 July 8, 2024 16:04
@kt474 kt474 removed this from the 0.25.0 milestone Jul 8, 2024
@kt474 kt474 merged commit 44022c9 into Qiskit:main Jul 9, 2024
18 checks passed
@kt474 kt474 deleted the fake-backend-methods branch July 9, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make fake backends more like IBMBackend
3 participants