Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider compatibility to the runtime service #419

Merged
merged 5 commits into from
Aug 9, 2022
Merged

Conversation

renier
Copy link
Contributor

@renier renier commented Jul 13, 2022

Summary

Adds provider compatibility to the runtime service. This allows us to pass the
runtime service to those algorithm classes that expect a base provider to call
provider.runtime.run(...) on, without needing upstream changes.

@renier renier marked this pull request as ready for review July 13, 2022 22:53
@coveralls
Copy link

coveralls commented Jul 13, 2022

Pull Request Test Coverage Report for Build 2826326303

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 62.649%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qiskit_runtime_service.py 4 6 66.67%
Totals Coverage Status
Change from base Build 2815089434: 0.2%
Covered Lines: 2900
Relevant Lines: 4629

💛 - Coveralls

@renier renier temporarily deployed to ibm-quantum-production July 13, 2022 23:07 Inactive
@rathishcholarajan
Copy link
Member

@renier Even though this looks harmless to merge, it was done from the point of view of fixing a bug. We need to think about this a bit more as part of a larger Epic.

Also usually when contributing to this repo it is recommended to fork this repo, work on a branch and then open a PR. That way PR builds won't run all integration tests and fail sometimes, but just the unit tests, which are enough to merge. People usually add their personal environment secrets to their fork as explained in the contribution guidelines and that way we know if integration tests pass on your fork, before merging.

@renier
Copy link
Contributor Author

renier commented Jul 14, 2022

@renier Even though this looks harmless to merge, it was done from the point of view of fixing a bug. We need to think about this a bit more as part of a larger Epic.

Yes, let's take time to discuss this first.

Also usually when contributing to this repo it is recommended to fork this repo, work on a branch and then open a PR. That way PR builds won't run all integration tests and fail sometimes, but just the unit tests, which are enough to merge. People usually add their personal environment secrets to their fork as explained in the contribution guidelines and that way we know if integration tests pass on your fork, before merging.

Ok, I admit I didn't read the guidelines. Will do that in the future.

@kt474 kt474 added the on hold label Jul 27, 2022
@renier
Copy link
Contributor Author

renier commented Jul 28, 2022

@stefan-woerner any objections to this?

@renier renier removed the on hold label Aug 5, 2022
@renier
Copy link
Contributor Author

renier commented Aug 5, 2022

@kt474 if you have no objections, please merge.

@renier renier temporarily deployed to ibm-quantum-production August 5, 2022 21:48 Inactive
@renier renier temporarily deployed to ibm-cloud-production August 5, 2022 21:48 Inactive
@kt474 kt474 temporarily deployed to ibm-quantum-production August 9, 2022 16:02 Inactive
@kt474 kt474 temporarily deployed to ibm-quantum-staging August 9, 2022 16:02 Inactive
@kt474 kt474 had a problem deploying to ibm-cloud-production August 9, 2022 16:02 Failure
@kt474 kt474 temporarily deployed to ibm-quantum-production August 9, 2022 16:07 Inactive
@kt474 kt474 temporarily deployed to ibm-cloud-production August 9, 2022 16:07 Inactive
@kt474 kt474 temporarily deployed to ibm-quantum-production August 9, 2022 17:06 Inactive
@kt474 kt474 temporarily deployed to ibm-quantum-staging August 9, 2022 17:06 Inactive
@kt474 kt474 temporarily deployed to ibm-cloud-production August 9, 2022 17:06 Inactive
@kt474 kt474 temporarily deployed to ibm-quantum-production August 9, 2022 17:33 Inactive
@kt474 kt474 temporarily deployed to ibm-quantum-staging August 9, 2022 17:33 Inactive
@kt474 kt474 temporarily deployed to ibm-cloud-production August 9, 2022 17:33 Inactive
@kt474 kt474 temporarily deployed to ibm-cloud-staging August 9, 2022 17:33 Inactive
@kt474 kt474 merged commit c27ba7f into main Aug 9, 2022
@kt474 kt474 deleted the provider-compat branch August 9, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants