-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider compatibility to the runtime service #419
Conversation
Pull Request Test Coverage Report for Build 2826326303
💛 - Coveralls |
@renier Even though this looks harmless to merge, it was done from the point of view of fixing a bug. We need to think about this a bit more as part of a larger Epic. Also usually when contributing to this repo it is recommended to fork this repo, work on a branch and then open a PR. That way PR builds won't run all integration tests and fail sometimes, but just the unit tests, which are enough to merge. People usually add their personal environment secrets to their fork as explained in the contribution guidelines and that way we know if integration tests pass on your fork, before merging. |
Yes, let's take time to discuss this first.
Ok, I admit I didn't read the guidelines. Will do that in the future. |
@stefan-woerner any objections to this? |
@kt474 if you have no objections, please merge. |
Summary
Adds provider compatibility to the runtime service. This allows us to pass the
runtime service to those algorithm classes that expect a base provider to call
provider.runtime.run(...)
on, without needing upstream changes.