improve warning when 1q synthesis emits long strings #7048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
added
Changelog: None
|
Maybe worth backporting for debug purposes if this keeps coming up? |
jakelishman
pushed a commit
that referenced
this pull request
Sep 21, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> (cherry picked from commit 6b08154)
mergify bot
added a commit
that referenced
this pull request
Sep 21, 2021
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> (cherry picked from commit 6b08154) Co-authored-by: Eric Peterson <peterson.eric.c@gmail.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The warning strings reported by users in #7041, #7033, and #7042 were made illegible by implicit use of
DAGNodeOp.__str__. This PR changes the generated warning string to something actually useful for debugging.Notes
I tested this change by hand, by replacing the default values for
simplify=Trueandallow_non_canonical=TruewithFalseinqiskit/quantum_info/synthesis/one_qubit_decompose.py. It's somewhat cumbersome to test this automatically.