Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement biparition_graph_mst and bipartition_tree functions #572

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Implement biparition_graph_mst and bipartition_tree functions #572

wants to merge 46 commits into from

Commits on May 28, 2022

  1. Draft bipartition_tree implementation

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    1cdf76a View commit details
    Browse the repository at this point in the history

  2. Working bipartition tree impl

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    20281b0 View commit details
    Browse the repository at this point in the history

  3. Release GIL during most of balanced_edge finding code

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f85eb52 View commit details
    Browse the repository at this point in the history

  4. Ensure that unused vars get gc'ed on each loop

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    79b3d94 View commit details
    Browse the repository at this point in the history

  5. Lint with cargo fmt

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    d5d464b View commit details
    Browse the repository at this point in the history

  6. Update to using built-in retworkx macros 

    Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @InnovativeInventor @mtreinish
    InnovativeInventor and mtreinish committed May 28, 2022
    Configuration menu
    Copy the full SHA
    e7409a5 View commit details
    Browse the repository at this point in the history

  7. Take advantage of built-in retworkx macros

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a45c147 View commit details
    Browse the repository at this point in the history

  8. Use mem::take to save on memory allocs

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    4d93f0e View commit details
    Browse the repository at this point in the history

  9. Revert "Use mem::take to save on memory allocs" 

    This reverts commit 46d0950.
    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f01201c View commit details
    Browse the repository at this point in the history

  10. Fix unnecessary clones; address clippy warnings

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    fdbeaaf View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary dead/commented out code

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    517d697 View commit details
    Browse the repository at this point in the history

  12. Reduce number of memory allocs

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    2bd4c33 View commit details
    Browse the repository at this point in the history

  13. Remove unused import

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    658ffa5 View commit details
    Browse the repository at this point in the history

  14. Remove no longer relevant todos

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a360695 View commit details
    Browse the repository at this point in the history

  15. Switch to using HashSet for seen_nodes tracker

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    c5d76cb View commit details
    Browse the repository at this point in the history

  16. Touch up comments to make more sense

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    6643195 View commit details
    Browse the repository at this point in the history

  17. Lint with cargo fmt

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    90d5ba3 View commit details
    Browse the repository at this point in the history

  18. Rename functions to biparition_tree and bipartition_graph; update docs

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    b522daa View commit details
    Browse the repository at this point in the history

  19. Make docstrings more descriptive and fix renaming issue

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    1e6290d View commit details
    Browse the repository at this point in the history

  20. Add release notes for bipartition_tree and bipartition_graph

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    c283355 View commit details
    Browse the repository at this point in the history

  21. Add bipartition_graph and bipartition_tree to API section of docs

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    cbaed09 View commit details
    Browse the repository at this point in the history

  22. Shorten description of weight_fn by pointing to minimum_spanning_tree… 

    … func
    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    41e503a View commit details
    Browse the repository at this point in the history

  23. Fix end with blank line linting issue

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    da1e8a7 View commit details
    Browse the repository at this point in the history

  24. Add bipartition tests

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    99e5257 View commit details
    Browse the repository at this point in the history

  25. Fix indent issues in retworkx bipartition docstrings

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    db87924 View commit details
    Browse the repository at this point in the history

  26. Switch to using hashbrown's HashSet impl 

    Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @InnovativeInventor @mtreinish
    InnovativeInventor and mtreinish committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f6d807c View commit details
    Browse the repository at this point in the history

  27. Make tests deterministic

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    46404f3 View commit details
    Browse the repository at this point in the history

  28. Reorder imports as per cargo fmt

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    1ea5cd1 View commit details
    Browse the repository at this point in the history

  29. Wrap in rst Python code block

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    79b5e17 View commit details
    Browse the repository at this point in the history

  30. Switch to passing by value for mst

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    4e00b9b View commit details
    Browse the repository at this point in the history

  31. Make test name more accurate

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    5ba7cc9 View commit details
    Browse the repository at this point in the history

  32. Handle holes in graph node indices

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    3685720 View commit details
    Browse the repository at this point in the history

  33. Revert "Switch to passing by value for mst" 

    This reverts commit 8e4ffdf.
    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    8e513f7 View commit details
    Browse the repository at this point in the history

  34. Remove return reference in _minimum_spanning_tree helper

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    c1f73a2 View commit details
    Browse the repository at this point in the history

  35. Rename bipartition_graph to bipartition_graph_mst

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f59f7c2 View commit details
    Browse the repository at this point in the history

  36. Create _bipartition_tree internal func

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    4088b76 View commit details
    Browse the repository at this point in the history

  37. Use numpy PyReadonlyArray to avoid one, unnecessary copy

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    663d54e View commit details
    Browse the repository at this point in the history

  38. Revert "Use numpy PyReadonlyArray to avoid one, unnecessary copy" 

    This reverts commit 53842ef.
    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a8f2305 View commit details
    Browse the repository at this point in the history

  39. Update pyo3 text_signature to reflect args 

    Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
    @InnovativeInventor @georgios-ts
    InnovativeInventor and georgios-ts committed May 28, 2022
    Configuration menu
    Copy the full SHA
    dd42700 View commit details
    Browse the repository at this point in the history

  40. Apply suggestions from @georgois-ts 

    Co-authored-by: georgios-ts <45130028+georgios-ts@users.noreply.github.com>
    @InnovativeInventor @georgios-ts
    InnovativeInventor and georgios-ts committed May 28, 2022
    Configuration menu
    Copy the full SHA
    7c131a1 View commit details
    Browse the repository at this point in the history

  41. Update pyo3 text_signature to reflect Rust args

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    aa24d61 View commit details
    Browse the repository at this point in the history

  42. Switch to using LinkedList for cheaper appends and remove unnecessary… 

    … queue traversal
    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    e7fdffe View commit details
    Browse the repository at this point in the history

  43. Remove LinkedList use

    @InnovativeInventor
    InnovativeInventor committed May 28, 2022
    Configuration menu
    Copy the full SHA
    4dc3ba7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Merge remote-tracking branch 'origin/main' into feat-balanced-cut-edges

    @IvanIsCoding
    IvanIsCoding committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    90df5ac View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feat-balanced-cut-edges

    @IvanIsCoding
    IvanIsCoding committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    5fd550a View commit details
    Browse the repository at this point in the history

  3. Move test file to rustworkx tests

    @IvanIsCoding
    IvanIsCoding committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    930069a View commit details
    Browse the repository at this point in the history