-
Notifications
You must be signed in to change notification settings - Fork 8
chore: improve local DX #9
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR. I really appreciate it. For the database initialization. I'd stick to letting the app manage properly to rollout database migrations (like this). It can be improved, and it's quite basic today. Still, I'd like to avoid asking users to do manual actions to start using Torii and ultimately upgrading it. The upgrades can be adequately handled by sequentially applying database changes. (cf my shared article with Flyway). WDYT? |
Hey @evoxmusic, Edit: I will fix the MR and resubmit again |
Thx @Tchoupinax 🙏🏽 - let's propose maybe two ways at some point. An automatic way and a much more safer/manual way if it makes sense. |
51a7323
to
02b6aa5
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10273821 | Triggered | Generic Password | 34deeb8 | docker-compose-dev.yaml | View secret |
10273821 | Triggered | Generic Password | 27689af | docker-compose.dev.yaml | View secret |
10273821 | Triggered | Generic Password | 8fbeda1 | docker-compose.dev.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Hello @evoxmusic, This merge request brings a edited docker compose to wake development environment with reloading on file changes (frontend is instant with vite, backend is just triggering a new compilation, that's said, you don't have to think about it! :) ) Another bonus is the usage of Tilt, that I love. I hope it meets expectations! |
Hey!
This work improves the developer experience to start the project locally:
docker-compose up
)I have an issue about loading the config in the container but maybe you could help me on this:
Edit: tested on Linux AMD64 environment, maybe on MacOS the docker compose's behaviour would be different
Thanks and have a nice day!