Add access to information on the source of an artifact dependency

[3breadt]

The ArtifactDependency class did not include information on the source build configuration of the dependency. This information is provided in the REST API in the "source-buildType" object.

I have added a new class SourceBuildType and added a corresponding property to the ArtifactDependency class. Now the build config information is automatically deserialized by EasyHttp.

[borismod]

Thanks for your contrubution. It will be accepted when the code is covered by test(s) that reproduce, demonstrate the fix. Also please create an issue and link it to your PR.

…

On Feb 2, 2017 11:09 AM, "Daniel Dreibrodt" ***@***.***> wrote: The ArtifactDependency class did not include information on the source build configuration of the dependency. This information is provided in the REST API in the "source-buildType" object. I have added a new class SourceBuildType and added a corresponding property to the ArtifactDependency class. Now the build config information is automatically deserialized by EasyHttp. ------------------------------ You can view, comment on, or merge this pull request online at: #91 Commit Summary - Add build config info for ArtifactDependencies - Add SourceBuildType property to ArtifactDependency File Changes - *M* FluentTc/Domain/ArtifactDependency.cs <https://github.com/QualiSystems/FluentTc/pull/91/files#diff-0> (7) - *A* FluentTc/Domain/SourceBuildType.cs <https://github.com/QualiSystems/FluentTc/pull/91/files#diff-1> (15) - *M* FluentTc/FluentTc.csproj <https://github.com/QualiSystems/FluentTc/pull/91/files#diff-2> (1) Patch Links: - https://github.com/QualiSystems/FluentTc/pull/91.patch - https://github.com/QualiSystems/FluentTc/pull/91.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#91>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAM0M1XavViEKYxzzeSF_Lm21t1xpj86ks5rYZ1EgaJpZM4L03cv> .

[3breadt]

I extended the unit test AcceptanceTests.GetBuildConfiguration_Id to cover artifact dependencies and the new SourceBuildType property.

This does not cover the actual deserialization of the REST response. But I found no quick way to mock the actual HTTP responses, which would have made the test much more meaningful.

I see that so far none of your unit tests actually do that, so I assume this unit test is acceptable for you.

Of course I manually tested the code against an actual TeamCity installation and it works just fine.

[borismod]

@3breadt thanks for your contribution