Feature/gabhijit izel 25 26 27 revisit attributes

[gabhijit-izel]

Description

Fixing a bunch of minor issues -

1. Image ID is taken as App attribute (not image name)
2. Quali Network UUID is taken as CP attribute (no longer hard coded)
3. Unwanted attributes are removed.

Related Stories

#25 #26 #27 #35

Breaking

Yes | NO :

Not sure. Previous data model will not work now. So one needs to start with a new database. This is not released yet, so not a big problem, but something dev/QA should keep in mind.

Breaking changes

• Breaking change description

  Detailed change info
  Migration steps

---

This change is

[coveralls]

Coverage decreased (-0.1%) to 95.036% when pulling c9bc0d0 on feature/gabhijit-izel_25_26_27_revisit_attributes into 87cc01c on develop.

[alexazarh]

Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

package/cloudshell/cp/openstack/command/operations/deploy_operation.py, line 24 at r1 (raw file):

        :param ReservationModel reservation:
        :param DeployDataHolder deploy_req_model:
        :param XXX cp_resource_model:

Is the "XXX" a type?

---

Comments from Reviewable

[coveralls]

Coverage decreased (-0.1%) to 95.036% when pulling f572970 on feature/gabhijit-izel_25_26_27_revisit_attributes into 87cc01c on develop.

[gabhijit-izel]

Review status: 12 of 13 files reviewed at latest revision, 1 unresolved discussion.

---

package/cloudshell/cp/openstack/command/operations/deploy_operation.py, line 24 at r1 (raw file):

Previously, alexazarh wrote…

Is the "XXX" a type?

Fixed

---

Comments from Reviewable

[alexazarh]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable