Skip to content

Conversation

gabhijit-izel
Copy link
Contributor

@gabhijit-izel gabhijit-izel commented Nov 16, 2016

Description

Review request FIXME comments for #15

Related Stories

#59 #60

Breaking

NO


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.393% when pulling 526a7a1 on feature/gabhijit-izel_15_poc_connectivity into f4c88fe on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.393% when pulling 526a7a1 on feature/gabhijit-izel_15_poc_connectivity into f4c88fe on develop.

Copy link
Contributor Author

@gabhijit-izel gabhijit-izel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, basically just added FIXMEs that were discussed during review.

@gabhijit-izel
Copy link
Contributor Author

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@gabhijit-izel gabhijit-izel merged commit bd9c3f9 into develop Nov 16, 2016
@gabhijit-izel gabhijit-izel deleted the feature/gabhijit-izel_15_poc_connectivity branch December 26, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants