Feature/gabhijit izel 59 60 vlan domain service #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added unit tests for neutron service Separated out all VLAN related stuff in a separate domain/service moved refresh_ip out of connectivity.
1. Port attributes is a JSON/Dict now 2. Wrapped subnet creation code in a lock 3. Changed attach_subnet_to_net name to create_and_attach_subnet_to_net
Improved coverage to up to 94%. All major function paths covered
|
Reviewed 16 of 16 files at r1. Comments from Reviewable |
gabhijit-izel
deleted the
feature/gabhijit-izel_59_60_vlan_domain_service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #59 and #60
Related Stories
#15
Breaking
NO
This change is