Feature/gabhijit izel 72 74 remove hardcoded

[gabhijit-izel]

Description

Removed following hard coded descriptions -

1. VLAN attribute
2. VLAN interface name
3. quali network

1 and 2 now come as Cloud Provider attributes

Related Stories

#15

Breaking

YES

Breaking changes

• Data model has changed now.

---

This change is 

[coveralls]

Coverage decreased (-0.4%) to 91.937% when pulling 0789898 on feature/gabhijit-izel_72_74_remove_hardcoded into 5d3e993 on develop.

[alexazarh]

Reviewed 7 of 16 files at r1.
Review status: 7 of 16 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

drivers/openstack_shellPackage/Configuration/shellconfig.xml, line 20 at r1 (raw file):

              <Attribute Name="Reserved Networks" Value="" />
              <Attribute Name="Quali Management Network UUID" Value=""/>
              <Attribute Name="Provider Network Type" Value=""/>

The name of the attribute should be "Vlan Type" according to QualiSystems/Azure-Shell#218

---

drivers/openstack_shellPackage/Configuration/shellconfig.xml, line 21 at r1 (raw file):

              <Attribute Name="Quali Management Network UUID" Value=""/>
              <Attribute Name="Provider Network Type" Value=""/>
              <Attribute Name="Provider Network Interface" Value=""/>

What is the purpose of this attribute?

---

Comments from Reviewable

[gabhijit-izel]

drivers/openstack_shellPackage/Configuration/shellconfig.xml, line 21 at r1 (raw file):

Previously, alexazarh wrote…

What is the purpose of this attribute?

This attribute is required during creating network . When we create a network there's a required attribute 'provider:physical_interface' that specifies which physical interface is to be used for this network on a given node.

---

Comments from Reviewable

[gabhijit-izel]

drivers/openstack_shellPackage/Configuration/shellconfig.xml, line 20 at r1 (raw file):

Previously, alexazarh wrote…

The name of the attribute should be "Vlan Type" according to QualiSystems/Azure-Shell#218

Ok. Will take care of this and update the review request.

---

Comments from Reviewable

[gabhijit-izel]

drivers/openstack_shellPackage/Configuration/shellconfig.xml, line 20 at r1 (raw file):

Previously, gabhijit-izel wrote…

Ok. Will take care of this and update the review request.

Done.

---

Comments from Reviewable

[coveralls]

Coverage decreased (-0.4%) to 91.937% when pulling 5b81fcf on feature/gabhijit-izel_72_74_remove_hardcoded into 5d3e993 on develop.

[alexazarh]

Reviewed 4 of 16 files at r1, 6 of 6 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable