Skip to content

fix #47 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2018
Merged

fix #47 #48

merged 3 commits into from
Jul 20, 2018

Conversation

saklar13
Copy link
Contributor

@saklar13 saklar13 commented Jul 20, 2018 •
edited by yaroslavNqualisystems
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Jul 20, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 51.033% when pulling d6a5374 on fix_#47 into 118ac36 on dev.

yaroslavNqualisystems
yaroslavNqualisystems approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@yaroslavNqualisystems yaroslavNqualisystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Costya-Y)

@yaroslavNqualisystems yaroslavNqualisystems merged commit b7bcb92 into dev Jul 20, 2018
@saklar13 saklar13 deleted the fix_#47 branch July 20, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Costya-Y Costya-Y Awaiting requested review from Costya-Y

1 more reviewer

@yaroslavNqualisystems yaroslavNqualisystems yaroslavNqualisystems approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saklar13 @coveralls @yaroslavNqualisystems