Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Use relative tolerance in test_tic_tac_toc #328

Merged
merged 1 commit into from
Aug 25, 2017
Merged

FIX: Use relative tolerance in test_tic_tac_toc #328

merged 1 commit into from
Aug 25, 2017

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Aug 18, 2017

test_tic_tac_toc sometimes fails on my machine. Change absolute tolerance to relative tolerance.

@coveralls
Copy link

coveralls commented Aug 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 92.614% when pulling 61e7e47 on test_timing into 188e5ba on master.

@mmcky mmcky self-requested a review August 18, 2017 03:12
mmcky
mmcky approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @oyamad this looks good.

@mmcky mmcky merged commit 2814190 into master Aug 25, 2017
@mmcky mmcky deleted the test_timing branch August 25, 2017 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oyamad @coveralls @mmcky