add minimum version number for numba support #409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
0.36.2
as a minimum numba version required for installation insetup.py
numba
is one of the key dependencies for QuantEcon.py. Given our user base -- it may be helpful to alternatively write a version check in the base__init__.py
file which would give us the opportunity to issue a more useful error message based onconda
.Could check if
numba.__version__ > minimum value
otherwise print out instructions to upgrade such asconda install numba=0.37
. Any comments welcome.