Skip to content

MAINT: update quantecon-book-theme=0.2.0 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2021
Merged

MAINT: update quantecon-book-theme=0.2.0 #138

merged 1 commit into from
May 11, 2021

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented May 6, 2021

This PR updates to quantecon-book-theme=0.2.0

@github-actions github-actions bot temporarily deployed to commit May 6, 2021 00:46 Inactive
@mmcky mmcky requested a review from shlff May 6, 2021 02:56
@mmcky
Copy link
Contributor Author

mmcky commented May 6, 2021

@shlff this is a build of: https://python-programming.quantecon.org/intro.html using the latest quantecon-book-theme.

@AakashGfude has done some nice work on refactoring our theme and adding some new features.

It would be great if you could spend a bit of time comparing the current live site with this PR build (as a double check).

Hopefully you won't find many differences :-)

@mmcky
Copy link
Contributor Author

mmcky commented May 6, 2021

@shlff also just to clarify - there is no need to recheck the whole site. Just wanted another set of eyes to:

  1. do some random spot checks
  2. look for some of the issues that have cropped up before

@shlff
Copy link
Member

shlff commented May 10, 2021

Thanks @mmcky , I randomly selected 3 lectures and here are the differences I spotted (maybe not issues; left: live website, right: preview of this PR):

[x] added signs:

Screen Shot 2021-05-10 at 1 31 55 pm

[x] Bold font for subsubsections
Screen Shot 2021-05-10 at 1 32 43 pm

[x] some problematic Latex output generated by code
Screen Shot 2021-05-10 at 1 34 34 pm

[x] different color for quoted in-text code
Screen Shot 2021-05-10 at 1 36 59 pm

[x] different style for quoted between-text code
Screen Shot 2021-05-10 at 1 37 57 pm

[x] extra spaces above and below the code
Screen Shot 2021-05-10 at 1 39 21 pm

@mmcky
Copy link
Contributor Author

mmcky commented May 10, 2021

nice work @shlff -- really helpful. thank you.

@mmcky
Copy link
Contributor Author

mmcky commented May 10, 2021

@AakashGfude any ideas on the LaTeX issue for output. Maybe I should change the priorities in the _config.yml to promote svg above LaTeX. Is mathjax not parsing the output blocks perhaps?

@mmcky
Copy link
Contributor Author

mmcky commented May 10, 2021

@shlff I am unable to replicate that issue in about_py for the sympy math output. Can you let me know what browser you're using.

I have safari running

Screen Shot 2021-05-10 at 2 22 10 pm

@shlff
Copy link
Member

shlff commented May 10, 2021

@shlff I am unable to replicate that issue in about_py for the sympy math output. Can you let me know what browser you're using.

I have safari running

Screen Shot 2021-05-10 at 2 22 10 pm

Thanks @mmcky . I double-checked it again and didn't see the same issue either. Please ignore this issue.

@mmcky
Copy link
Contributor Author

mmcky commented May 11, 2021

thanks again @shlff I think these difference in style are OK. It is really helpful to have these differences documented like this though.

I will go ahead and merge this to update the theme.

cc: @jstac

@mmcky mmcky merged commit 846e4f2 into master May 11, 2021
@mmcky mmcky deleted the theme=0.2.0 branch May 11, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants