-
-
Notifications
You must be signed in to change notification settings - Fork 29
Chapter 3 Review: Add Explanations and Address Exercise Issue #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @HumphreyYang , thanks for these changes and suggestions. Do you have time to chat quickly about this? If so please email me a google meet or zoom invitation. |
Hi @jstac, Thank you for your kind comment. I have simplified the previous version and corrected the comment in the exercise. Could you please kindly review this version and merge it whenever you find it appropriate? |
Great work @HumphreyYang . Sorry for the bother but could you please also
After that I'll merge. |
Hi @jstac, Thank you for your comment. I have updated the page accordingly, and I will try to be more concise in the future. Please kindly merge if you think it looks good to you now. Thank you. |
Hmmm, it doesn't look like the last changes went through when I click on the "Deployed on" link above https://62e9f3f85edd124d6f813070--epic-agnesi-957267.netlify.app/python_by_example.html |
Hi @jstac, The latest deployment is associated with this commit, and the link to the deployment is here. All changes have been reflected in the latest deployment. The deployment you shared (https://62e9f3f85edd124d6f813070--epic-agnesi-957267.netlify.app/) is associated with a commit two days ago, which is outdated. I am not sure why the sequence of deployment is reversed on this page, but on the commit page, it seems to be correct. |
Perfect, thanks @HumphreyYang . Nice work. I'll go ahead and merge. Can you please open an issue stating that all exercise / solution groups should be modified to the format used here? |
Hi @jstac and @mmcky,
I have finished the review of Chapter 3. The following changes have been made:
Could you please kindly review the changes and provide some feedback on the changes?
Thank you.