Skip to content

Conversation

HumphreyYang
Copy link
Member

@HumphreyYang HumphreyYang commented Aug 2, 2022

Hi @jstac and @mmcky,

I have finished the review of Chapter 3. The following changes have been made:

  1. Added explanations for while loop and solution for exercise 5;
  2. Added a line of code to find the location of the library in Python;
  3. addressed Shift exercise solutions to immediately after exercises #192 in Chapter 3.

Could you please kindly review the changes and provide some feedback on the changes?

Thank you.

@HumphreyYang HumphreyYang changed the title Chapter 3 Review: Add Explanations and Address Issue #192 (Exercise Location) Chapter 3 Review: Add Explanations and Address Issue #192 Aug 2, 2022
@HumphreyYang HumphreyYang changed the title Chapter 3 Review: Add Explanations and Address Issue #192 Chapter 3 Review: Add Explanations and Address Exercise Issue Aug 2, 2022
@github-actions github-actions bot temporarily deployed to commit August 2, 2022 07:33 Inactive
@jstac
Copy link
Contributor

jstac commented Aug 2, 2022

Hi @HumphreyYang , thanks for these changes and suggestions.

Do you have time to chat quickly about this? If so please email me a google meet or zoom invitation.

@github-actions github-actions bot temporarily deployed to commit August 3, 2022 01:47 Inactive
@HumphreyYang
Copy link
Member Author

Hi @jstac,

Thank you for your kind comment. I have simplified the previous version and corrected the comment in the exercise.

Could you please kindly review this version and merge it whenever you find it appropriate?

@jstac
Copy link
Contributor

jstac commented Aug 3, 2022

Great work @HumphreyYang .

Sorry for the bother but could you please also

  1. delete the sentence "In fact, you can find and explore the directory for NumPy on your computer easily enough if you look around." I think it's now redundant, given your addition.
  2. change "We’ll learn all about methods later on in Object Oriented Programming..." to "We'll learn all about methods later on..."

After that I'll merge.

@HumphreyYang
Copy link
Member Author

Hi @jstac,

Thank you for your comment. I have updated the page accordingly, and I will try to be more concise in the future.

Please kindly merge if you think it looks good to you now.

Thank you.

@github-actions github-actions bot temporarily deployed to commit August 3, 2022 03:40 Inactive
@jstac
Copy link
Contributor

jstac commented Aug 3, 2022

Hmmm, it doesn't look like the last changes went through when I click on the "Deployed on" link above

https://62e9f3f85edd124d6f813070--epic-agnesi-957267.netlify.app/python_by_example.html

@HumphreyYang
Copy link
Member Author

HumphreyYang commented Aug 3, 2022

Hi @jstac,

The latest deployment is associated with this commit, and the link to the deployment is here. All changes have been reflected in the latest deployment.

The deployment you shared (https://62e9f3f85edd124d6f813070--epic-agnesi-957267.netlify.app/) is associated with a commit two days ago, which is outdated.

I am not sure why the sequence of deployment is reversed on this page, but on the commit page, it seems to be correct.

@jstac
Copy link
Contributor

jstac commented Aug 3, 2022

Perfect, thanks @HumphreyYang . Nice work.

I'll go ahead and merge.

Can you please open an issue stating that all exercise / solution groups should be modified to the format used here?

@jstac jstac merged commit e2994ac into main Aug 3, 2022
@github-actions github-actions bot temporarily deployed to commit August 3, 2022 04:48 Inactive
@HumphreyYang HumphreyYang deleted the lec-review-3 branch August 8, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants