Skip to content

Conversation

HumphreyYang
Copy link
Member

Hi @jstac,

I implemented the following changes in this PR:

  1. I found images on the page will be distorted when the size of the browser window is changed, or when the reader is reading the page on their phone. To improve readability, I added two CSS classes to make the size of images in this chapter variable according to the size of the browser;
  2. fixed replace np.rank with np.dim #186 ;
  3. fixed Chapter 2: Exercise 2.1 Format Issue #195 ;
  4. added a reference to docstring in python essential;
  5. updated links.

Could you please kindly review these changes and suggest where I should further improve?

Many thanks in advance.

Comment on lines 157 to 159
```{figure} /_static/lecture_specific/getting_started/starting_nb.png
:scale: 60
:figclass: terminal
```
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only image I did not replace is the terminal view. It is because there are no significant changes in the terminal output.

@github-actions github-actions bot temporarily deployed to commit August 20, 2022 05:38 Inactive
@jstac
Copy link
Contributor

jstac commented Aug 20, 2022

Great work @HumphreyYang ! Excellent work and excellent PR.

I have no requested changes so I'll go ahead and merge. Many thanks.

@jstac jstac merged commit 1da76ec into main Aug 20, 2022
@jstac jstac deleted the lec-review-2 branch August 20, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter 2: Exercise 2.1 Format Issue replace np.rank with np.dim
2 participants