This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Undeprecate "Optimal Savings II: LQ Techniques" #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2018 11:14
Nosferican
changed the title
|
Don't worry about it. If there are non trivial updates I can take care of those and you can review those. In case you feel like it might be quite easy, is a matter of changing it to a for loop and iterate it directly. I updated a case like that a few PR ago. One of the structs has a never finish iterator so you can use |
|
Perfect, thanks. Didn't dive too deep onto the internals on this, but that sounds good. |
Needs Plotly to Plots
Nosferican
changed the title
|
@Nosferican This is ready to review now. |
|
I didn't see any tests on this lecture, no? |
|
Yeah, the name on this PR should be amended. I fixed it. |
arnavs
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.Also: There's a function the v0.6 function relies on (
start(moment_generator), wheremoment_generator = moment_sequence(lss)) which isn't in the latest tagged release of QuantEcon (v0.18.1). @Nosferican, how should I proceed?