This repository was archived by the owner on Apr 24, 2020. It is now read-only.
Simplified the answer to exercise 3 in python essentials #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faster, more pythonic and use techniques explained in the text
|
Thanks @jez-w ! I think it might be best to keep the original version and then show your new version. (The original might be easier for beginners to understand.) Would you mind to change the PR in that way? You can follow the original with "Here's another version that's more Pythonic" and then put in your one. |
understand. The short solution has been left as an alternative.
|
Perfect, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it simpler, faster, more pythonic and use techniques explained in the chapter text.
There is no need to check
isalpha()asisupper()only works for letters