Skip to content

Conversation

ytausch
Copy link
Member

@ytausch ytausch commented Sep 18, 2025

Closes #143.


If this is released, the feedstock should add a version constraint on pydantic_core.

@github-actions github-actions bot added the enhancement New feature or request label Sep 18, 2025
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fbecd10) to head (0a6007c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        51    +1     
  Lines         2841      2896   +55     
=========================================
+ Hits          2841      2896   +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ytausch!

I have no pre-existing experience with custom types in pydantic, so my review on that front relies on understanding the tests. Overall, I just have pretty minor comments.

@ytausch ytausch marked this pull request as draft September 19, 2025 12:30
@ytausch ytausch marked this pull request as ready for review September 19, 2025 13:20
Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @ytausch, looks almost done to me! @borchero I think you also talked with @ytausch about this, so let me know if you still want to review as well

@ytausch
Copy link
Member Author

ytausch commented Sep 19, 2025

side note: there are some CI checks not marked as required, is that intended?

@AndreasAlbertQC
Copy link
Collaborator

side note: there are some CI checks not marked as required, is that intended?

Nope, fixed, thanks for pointing it out :)

Co-authored-by: Andreas Albert <103571926+AndreasAlbertQC@users.noreply.github.com>
Copy link
Collaborator

@AndreasAlbertQC AndreasAlbertQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for bearing with all the fine-tuning :) I just checked in with @borchero and he asked to take a look before we merge, so let's please wait for his review.

Co-authored-by: Andreas Albert <103571926+AndreasAlbertQC@users.noreply.github.com>
@AndreasAlbertQC
Copy link
Collaborator

@borchero to avoid vacation-related hold-ups, we decided to mark this functionality as unstable and go ahead with the PR.

@AndreasAlbertQC AndreasAlbertQC merged commit 5d1c4d7 into main Sep 23, 2025
22 checks passed
@AndreasAlbertQC AndreasAlbertQC deleted the pydantic branch September 23, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Dataframes as Fields in Pydantic Models by Implementing __get_pydantic_core_schema__
2 participants