Update ci.yaml #163
Update ci.yaml #163
Conversation
Allowing fork-pull workflow
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
===========================================
- Coverage 93.73% 36.51% -57.23%
===========================================
Files 16 16
Lines 1835 1835
===========================================
- Hits 1720 670 -1050
- Misses 115 1165 +1050 |
| steps: | ||
| - name: Checkout branch | ||
| uses: actions/checkout@v3 | ||
| with: |
There was a problem hiding this comment.
Would we also need to remove this for all of the respective integration tests?
More removals
.github/workflows/ci.yaml
Outdated
| uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ github.head_ref }} | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
nit: This fetches the entire history. Is this to run some backwards compatibility test?
There was a problem hiding this comment.
You mean it should be fetch-depth: 1? Which most likely is the default I guess.
I don't think there is any good reason why we do this.
There was a problem hiding this comment.
Yeah might be better to just remove the entire with block for simplicity.
There was a problem hiding this comment.
I think fetch-depth is used in our repositories because setuptools-scm uses Git tags to determine the version when building and most our projects use it for packaging.
Default depth
Allowing fork-pull workflow