Skip to content

Conversation

jonashaag
Copy link
Contributor

(Untested)

@kklein
Copy link
Collaborator

kklein commented May 5, 2022

Do you want me to point read the docs to this branch?

@jonashaag
Copy link
Contributor Author

Does RTD support branch builds? Or I guess we should make a docs build part of the CI (with no dependency on RTD)

@kklein
Copy link
Collaborator

kklein commented May 5, 2022

I tried to enable building documentation for PRs. There is also some functionality to integrate that as part of CI but I'm afraid I don't have sufficient permissions to do so.

https://datajudge.readthedocs.io/en/jonashaag-patch-1/

@jonashaag
Copy link
Contributor Author

Nice, the links seems to work so this is ready to review

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kklein
Copy link
Collaborator

kklein commented May 30, 2022

Hi @jonashaag ! Should we merge this?

@jonashaag jonashaag merged commit b7d75d2 into main May 30, 2022
@kklein kklein deleted the jonashaag-patch-1 branch June 1, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants