Fix data processing error in tutorial #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklein
commented
Aug 12, 2022
| constraints. The ``VarCharRegex`` constraint compared the columns' values to a regular | ||
| expression. The ``UniquesEquality`` constraint expected the unique values of the | ||
| ``language`` column to not have changed between version 1 and version 2. | ||
| * The failing ``KolmogorovSminrnov`` constraint tells us that we shouldn't assume the |
There was a problem hiding this comment.
This test only failed due to a bug in the data processing.
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 93.90% 93.90%
=======================================
Files 15 15
Lines 1607 1607
=======================================
Hits 1509 1509
Misses 98 98
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kklein
commented
Aug 12, 2022
| df_v2[fluctuating_column] = ((1 + change) * df_v1[fluctuating_column]).astype(int) | ||
|
|
||
| # Make old version not have data about all channels from current version. | ||
| df_v1 = df_v1.sample(frac=0.85, random_state=SEED) |
There was a problem hiding this comment.
Previously, this subsampling happened before the numeric perturbations but after the copying.
Hence, df_v2 only received updated values for the subsampled rows/indices. Remaining rows/indices were assigned NA values.
kklein
commented
Aug 12, 2022
| # Introduce a data error. | ||
| index = (~df_v2["channel"].isin(df_v1["channel"])).idxmax() | ||
| df_v2.loc[index, "language"] = "Sw3d1zh" | ||
| df_v1 = pd.read_csv("twitch_version1.csv") |
There was a problem hiding this comment.
Dump to file system such that a separate upload script can be run even when not running the processing oneself.
ivergara
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered docs:
https://datajudge--51.org.readthedocs.build/en/51/