Skip to content

Conversation

Quantisan
Copy link
Owner

Fixes #4 by:

  1. run as USER leinuser
  2. verifying download signatures

And, use lein-pkg instead of lein script as it should.

@Quantisan Quantisan mentioned this pull request Apr 15, 2015
@Quantisan Quantisan force-pushed the feature/verify-download-signatures branch from 2f6eb02 to 37ffc19 Compare April 15, 2015 01:30
@Quantisan Quantisan force-pushed the feature/verify-download-signatures branch from 37ffc19 to 23199dd Compare April 15, 2015 01:47
@ToBeReplaced
Copy link

Nice one! This alleviates all of my concerns.

@md5
Copy link

md5 commented Apr 17, 2015

It would probably be good to combine some of the RUN statements. I just built this image at it looks like it currently has ~30 layers, which is getting perilously close to the 42 layer limit in older versions of AUFS (cf. moby/moby#1171). That limit is 127 layers in newer versions of AUFS as I understand it, but I assume there are still a lot of AUFS-based systems dealing with the older limit. The java:7 image itself is 8 layers (not counting scratch) and another instruction was recently added to the Dockerfile in docker-library/openjdk#34 that will be pushed live soon.

@lvh
Copy link

lvh commented Apr 30, 2015

This looks good to me, but I too think it'd be a good idea to merge some of those RUNs :)

@Quantisan Quantisan merged commit 69baafa into master May 8, 2015
@Quantisan Quantisan deleted the feature/verify-download-signatures branch September 1, 2015 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't run as root

4 participants