Skip to content

Conversation

VarLad
Copy link
Contributor

@VarLad VarLad commented May 31, 2021

When merged,the iframe would become consistent for the tutorials
A demo can be seen here https://varlad.github.io/tutorials/

@VarLad
Copy link
Contributor Author

VarLad commented May 31, 2021

@Roger-luo I guess this completes the currently asked task
There are many improvements to be made later though (Check out QuantumBFS/Yao.jl#282 (comment))
I'll work on them one by one.
For now, this task is complete

@Roger-luo
Copy link
Member

For now, this task is complete

IMO, this doesn't complete QuantumBFS/Yao.jl#278 but only adds the iframe resizer, we are far from finishing that issue with this.

you will also need to fix the Documenter issue I mentioned to close that issue.

@Roger-luo
Copy link
Member

Also I think this implementation is not right, we should use the npm package instead of pushing the entire iframe resizer code into the repo, on the other hand, the best approach is to use the CDN.

@VarLad VarLad changed the title Fixed the site Fixed the tutorials May 31, 2021
@VarLad
Copy link
Contributor Author

VarLad commented May 31, 2021

@Roger-luo When the CI has completed, if its good to go, kindly merge the PR

I'll be continuing with the Documenter problem

@Roger-luo Roger-luo merged commit bfd454a into QuantumBFS:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants